[AutoPR azure-resourcemanager-monitor-slis]-generated-from-SDK Generation - Java-6195147#48903
Conversation
…-9131 Add agentic workflow mergefest
…rosoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195147 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
…emanager-monitor-slis-6195147
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds a newly generated Java management SDK module, azure-resourcemanager-monitor-slis, produced from the Microsoft.Monitor/Slis TypeSpec configuration and wires it into the repo build/release pipeline.
Changes:
- Added the new
azure-resourcemanager-monitor-slisMaven module and registered it in thesdk/monitorparent and CI pipeline. - Introduced generated client/manager APIs, models, samples, and unit tests for the
Microsoft.MonitorSLIs RP (2025-03-01-preview). - Updated eng versioning metadata to include the new artifact.
Reviewed changes
Copilot reviewed 57 out of 82 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/monitor/pom.xml | Registers the new azure-resourcemanager-monitor-slis module under sdk/monitor. |
| sdk/monitor/ci.yml | Adds pipeline parameters and release entry for the new module. |
| sdk/monitor/azure-resourcemanager-monitor-slis/tsp-location.yaml | Records the source spec repo path/commit used for generation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/WindowUptimeCriteriaTests.java | Adds generated serialization/deserialization coverage for WindowUptimeCriteria. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/UserAssignedIdentityTests.java | Adds generated test scaffolding for UserAssignedIdentity. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/TemporalAggregationTests.java | Adds generated serialization/deserialization coverage for TemporalAggregation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SpatialAggregationTests.java | Adds generated serialization/deserialization coverage for SpatialAggregation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisListByParentMockTests.java | Adds mock test for Slis.listByParent. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisGetWithResponseMockTests.java | Adds mock test for Slis.getWithResponse. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisDeleteByResourceGroupWithResponseMockTests.java | Adds mock test for Slis.deleteByResourceGroupWithResponse. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SlisCreateOrUpdateWithResponseMockTests.java | Adds mock test for Slis.createOrUpdateWithResponse. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SliListResultTests.java | Adds generated test for list result paging model. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SignalTests.java | Adds generated serialization/deserialization coverage for Signal. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/SignalSourceTests.java | Adds generated serialization/deserialization coverage for SignalSource. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/MetricTests.java | Adds generated deserialization coverage for Metric. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/ManagedServiceIdentityTests.java | Adds generated serialization/deserialization coverage for ManagedServiceIdentity. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/ExecutionStateTests.java | Adds generated deserialization coverage for ExecutionState. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/ConditionTests.java | Adds generated serialization/deserialization coverage for Condition. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/BaselineTests.java | Adds generated serialization/deserialization coverage for Baseline. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/BaselinePropertiesTests.java | Adds generated serialization/deserialization coverage for BaselineProperties. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/test/java/com/azure/resourcemanager/monitor/slis/generated/AmwAccountTests.java | Adds generated serialization/deserialization coverage for AmwAccount. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/samples/java/com/azure/resourcemanager/monitor/slis/generated/SlisListByParentSamples.java | Adds generated sample for list operation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/samples/java/com/azure/resourcemanager/monitor/slis/generated/SlisGetSamples.java | Adds generated sample for get operation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/samples/java/com/azure/resourcemanager/monitor/slis/generated/SlisDeleteSamples.java | Adds generated sample for delete operation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/samples/java/com/azure/resourcemanager/monitor/slis/generated/SlisCreateOrUpdateSamples.java | Adds generated sample for create/update operation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/resources/azure-resourcemanager-monitor-slis.properties | Adds resource properties file used for version/user-agent. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-monitor-slis/reflect-config.json | Adds native-image reflect config placeholder. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/resources/META-INF/native-image/com.azure.resourcemanager/azure-resourcemanager-monitor-slis/proxy-config.json | Adds native-image proxy config for the service interface. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/resources/META-INF/azure-resourcemanager-monitor-slis_metadata.json | Adds generation metadata and cross-language mapping. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/module-info.java | Defines JPMS module exports/opens for serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/package-info.java | Adds package documentation for the main package. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/package-info.java | Adds package documentation for model types. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/WindowUptimeCriteriaComparator.java | Adds generated expandable enum for uptime comparator. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/WindowUptimeCriteria.java | Adds model + JSON serialization for uptime criteria. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/UserAssignedIdentity.java | Adds model for user-assigned identity (read-only fields). |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/TemporalAggregationType.java | Adds generated expandable enum for temporal aggregation types. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/TemporalAggregation.java | Adds model + JSON serialization for temporal aggregation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SpatialAggregationType.java | Adds generated expandable enum for spatial aggregation types. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SpatialAggregation.java | Adds model + JSON serialization for spatial aggregation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Slis.java | Adds public collection API interface for SLIs. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SliResource.java | Adds root resource properties model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SliProperties.java | Adds SLI evaluation properties model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Sli.java | Adds public immutable SLI resource interface. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SignalSource.java | Adds model + JSON serialization for signal sources. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Signal.java | Adds model + JSON serialization for signals. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ScalarFunction.java | Adds generated expandable enum for scalar functions. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/SamplingType.java | Adds generated expandable enum for sampling type. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ProvisioningState.java | Adds generated expandable enum for provisioning state. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Metric.java | Adds metric model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ManagedServiceIdentityType.java | Adds managed identity type expandable enum. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ManagedServiceIdentity.java | Adds MSI container model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ExecutionState.java | Adds execution state model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/EvaluationType.java | Adds evaluation type expandable enum. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/EvaluationCalculationType.java | Adds evaluation calculation type expandable enum. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/ConditionOperator.java | Adds filter operator expandable enum. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Condition.java | Adds condition model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Category.java | Adds SLI category expandable enum. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/BaselineProperties.java | Adds baseline properties model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/Baseline.java | Adds baseline model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/models/AmwAccount.java | Adds AMW account model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/package-info.java | Adds package documentation for implementation package. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/models/SliListResult.java | Adds list result implementation model + JSON serialization. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/SlisManagementClientImpl.java | Adds generated management client implementation and LRO helpers. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/SlisManagementClientBuilder.java | Adds builder to create the management client. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/SlisImpl.java | Adds public Slis collection implementation wrapping the fluent client. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/SliImpl.java | Adds public Sli wrapper implementation. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/implementation/ResourceManagerUtils.java | Adds paging + ARM ID parsing helpers used by wrappers. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/fluent/package-info.java | Adds package documentation for fluent client package. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/fluent/models/package-info.java | Adds package documentation for fluent inner models. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/fluent/models/SliInner.java | Adds the inner proxy resource model for the SLI. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/fluent/SlisManagementClient.java | Adds fluent management client interface. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/fluent/SlisClient.java | Adds fluent resource client interface. |
| sdk/monitor/azure-resourcemanager-monitor-slis/src/main/java/com/azure/resourcemanager/monitor/slis/SlisManager.java | Adds the entry-point manager and pipeline configuration builder. |
| sdk/monitor/azure-resourcemanager-monitor-slis/pom.xml | Adds Maven module metadata and dependencies. |
| sdk/monitor/azure-resourcemanager-monitor-slis/SAMPLE.md | Adds consolidated generated code snippets for docs. |
| sdk/monitor/azure-resourcemanager-monitor-slis/README.md | Adds package README with getting-started instructions. |
| sdk/monitor/azure-resourcemanager-monitor-slis/CHANGELOG.md | Adds initial changelog entry for 1.0.0-beta.1. |
| eng/versioning/version_client.txt | Registers the new artifact in versioning manifest. |
Comments suppressed due to low confidence (1)
sdk/monitor/azure-resourcemanager-monitor-slis/tsp-location.yaml:1
additionalDirectories:is present but has no value (and includes trailing whitespace). If tooling expects a list, this may be interpreted asnulland break processing. Prefer either removing the key entirely when unused or setting an explicit empty list (e.g.,additionalDirectories: []).
|
namespace review completed https://github.com/Azure/azure-sdk-pr/issues/2567 |
|
/azp run prepare-pipelines |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
…emanager-monitor-slis-6195147
|
/azp run prepare-pipelines |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@weidongxu-microsoft Can you please help tag someone else who can approve it? Since you pushed last, we need another reviewer to approve |
|
@XiaofeiCao for review and merge |
|
merged |
|
/azp run prepare-pipelines |
|
It's already ran #48903 (comment) release pipeline is https://dev.azure.com/azure-sdk/internal/_build?definitionId=2083, select your package and unselect others |
Configurations: 'specification/monitoringservice/resource-manager/Microsoft.Monitor/Slis/tspconfig.yaml', and CommitSHA: 'd32a3f6cc49c6dd6604161f8c7cee7c95a84c578' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6195147 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=2f8fce48-d33d-f111-88b4-000d3a5b007c Submitted by: Saleel.Kattiyat@microsoft.com
Release Plan Details
Spec pull request: Exclude SloView operations from SDK generation azure-rest-api-specs#42529
Spec API version: 2025-03-01-preview